createRegExpRestore explodes with an unmatched parenthesis #231

azimux · 2016-09-24T16:13:50Z

Hey hey!

We just noticed this problem after upgrading Intl. We see this failure sometimes in poltergeist and also seemed to be causing problems with our site loading in Safari:

Unhandled promise rejection SyntaxError: Invalid regular expression: unmatched parentheses

Printing out the evolution of the regex string it's trying to construct, it undergoes this path through the createRegExpRestore method before exploding when the end result [\s\S]{26}(((((((())))))))[\s\S]{38}) has an unmatched ) at the end.:

lastMatch:
function defineProperty() {
    [native code]
}
lm:
function defineProperty\(\) \{
    \[native code\]
\}
exprStr:
function defineProperty\(\) \{
    \[native code\]
\}
exprStr:
[\s\S]{52}
lastMatch:
function defineProperty\(\) \{
    \[native code\]
\}
lm:
function defineProperty\\\(\\\) \\\{
    \\\[native code\\\]
\\\}
has:
}
m:
}
lm:
function defineProperty\\\(\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
function defineProperty\\\(\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
()\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
()\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
)\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
())\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
())\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
))\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
()))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
()))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
)))\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
())))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
())))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
))))\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
()))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
()))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
)))))\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
())))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
())))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
()))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
()))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
)))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
m:

lm:
())))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
())))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
lm:
))))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
exprStr:
function defineProperty\\\((((((((())))))))\\\) \\\{
    \\\[native code\\\]
\\(\})
exprStr:
[\s\S]{26}(((((((())))))))[\s\S]{38})

The text was updated successfully, but these errors were encountered:

caridy · 2016-09-25T20:48:59Z

@azimux, did you try to use IntlPolyfill.__disableRegExpRestore? this seems related to #197

azimux · 2016-09-26T18:18:46Z

We didn't try that but seems like that would work since it would short-circuit the failing code.

We fixed it by just rolling back to the previous version we were using, from 1.2.5^ to 1.1.0.

#197 seems to be related to the length being long, and, subjective, but the length of the lastMatch here doesn't seem very long to me. Also that issue is from June 30th and was closed on the 5th, the same day a commit went in heavily changing that method to the form we were using, making me think that it's a different issue, and, actually the Jul 5th issue might even introduce the bug mentioned in this issue: aa62d07#diff-34a6d62af0cf0b784f8444529f3130efR134

MarkChrisLevy · 2016-10-18T17:47:45Z

I have the same problem - after upgrading to 1.2.5 (from 1.2.4), in Safari 9.1 (11601.5.17.1).

[log] [\s\S]{15}(((((((())))))))[\s\S]{38}) (Intl.min.js, line 1)
[Error] SyntaxError: Invalid regular expression: unmatched parentheses

Just downgraded to 1.2.4 and it works again.

caridy · 2016-10-18T18:05:22Z

@mtlewis can you help with this investigation?

mtlewis · 2016-10-18T20:09:15Z

@caridy sure thing, looking now.

mtlewis · 2016-10-18T22:04:53Z

Thanks for reporting this issue @azimux. To help us reproduce, would you mind logging out the value of the properties below at the start of the createRegExpRestore method please? Once I can reproduce the issue I should be able to track down the cause.

RegExp.input
RegExp.leftContext
RegExp.multiline
RegExp.$1
RegExp.$2
RegExp.$3
RegExp.$4
RegExp.$5
RegExp.$6
RegExp.$7
RegExp.$8
RegExp.$9

azimux · 2016-10-19T19:06:21Z

@mtlewis When it explodes, here's what those values are:

RegExp.input = function defineProperty\(\) \{
    \[native code\]
\}
RegExp.leftContext = 
RegExp.multiline = false
RegExp.$1 = }
RegExp.$2 = 
RegExp.$3 = 
RegExp.$4 = 
RegExp.$5 = 
RegExp.$6 = 
RegExp.$7 = 
RegExp.$8 = 
RegExp.$9 =

Btw, I really dug The Big Short. Read it twice. Nice work, sir, nice work!

azimux · 2016-10-19T19:13:16Z

Hmmm, probably better if I give you the JSON.stringify of the values so you can plug it in more easily:

createRegExpRestore intlRegExp.input = "function defineProperty\\(\\) \\{\n    \\[native code\\]\n\\}"
createRegExpRestore intlRegExp.leftContext = ""
createRegExpRestore intlRegExp.multiline = false
createRegExpRestore intlRegExp.$1 = "}"
createRegExpRestore intlRegExp.$2 = ""
createRegExpRestore intlRegExp.$3 = ""
createRegExpRestore intlRegExp.$4 = ""
createRegExpRestore intlRegExp.$5 = ""
createRegExpRestore intlRegExp.$6 = ""
createRegExpRestore intlRegExp.$7 = ""
createRegExpRestore intlRegExp.$8 = ""
createRegExpRestore intlRegExp.$9 = ""

…storation issues

…xpRestore

mtlewis · 2016-10-20T23:19:01Z

Thanks a lot for getting back to me @azimux. Phew! This was a doozy. A couple of problems to track down with the previous implementation of createRegExpRestore. All sorted in #244 I believe.

@caridy, mind taking a look at the PR?

…storation issues

…xpRestore

mtlewis · 2016-10-20T23:24:44Z

@caridy also, is the plan still to release a new major version which disables RegEx cache/restore by default?

…xpRestore

…xRestore Previously this expression contains a fragment similar to /aa*/ - have simplified this to /a+/.

wojtekmaj · 2016-12-16T11:13:54Z

Had the same problem, rollback to 1.2.4 helped right away.

fetis · 2017-03-14T15:07:25Z

Got the same problem with Angular DatePipe (yes, it uses Intl internally), rollback to 1.2.4 helped as was mentioned above.

caridy · 2017-04-03T05:08:47Z

Did you try to disabled the regexp cache? More details here: https://github.com/andyearnshaw/Intl.js#locale-data, read the second paragraph, and let us know.

Blasz · 2017-05-02T04:56:04Z

@caridy Disabling regexp cache fixed the issue for me.

EwanMcP · 2017-05-08T10:34:14Z

Also had the same issue, disabling cache worked but decided to revert to 1.2.4 for time being.

jerone · 2017-05-16T17:20:44Z

Having the same issue. Rolling back to 1.2.4 solved it. This issue should clearly be reopened!

neutraali · 2020-10-16T10:41:43Z

Spent hours fighting with this bug. Finally got it working in 1.2.5 by using Intl.__disableRegExpRestore() - Props to @caridy.

mtlewis pushed a commit to mtlewis/Intl.js that referenced this issue Oct 20, 2016

(bug andyearnshaw#231) Initial fix for escaped paren related regex re…

d64b709

…storation issues

mtlewis pushed a commit to mtlewis/Intl.js that referenced this issue Oct 20, 2016

(bug andyearnshaw#231) Simplifications and improvements to createRege…

a822a2f

…xpRestore

mtlewis mentioned this issue Oct 20, 2016

bug/231/fix regexp restore paren handling #244

Merged

DzmitryShylovich mentioned this issue Oct 20, 2016

refactor(facade): cleanup Intl facade angular/angular#12418

Closed

mtlewis added a commit to mtlewis/Intl.js that referenced this issue Oct 20, 2016

(bug andyearnshaw#231) Initial fix for escaped paren related regex re…

06012a9

…storation issues

mtlewis added a commit to mtlewis/Intl.js that referenced this issue Oct 20, 2016

(bug andyearnshaw#231) Simplifications and improvements to createRege…

74edeca

…xpRestore

mtlewis added a commit to mtlewis/Intl.js that referenced this issue Oct 21, 2016

(bug andyearnshaw#231) Simplifications and improvements to createRege…

d150c95

…xpRestore

mtlewis added a commit to mtlewis/Intl.js that referenced this issue Oct 21, 2016

(bug andyearnshaw#231) Simplifications and improvements to createRege…

f91377b

…xpRestore

mtlewis added a commit to mtlewis/Intl.js that referenced this issue Oct 26, 2016

(andyearnshaw#231) simplify regex compacting expression in createRege…

c3ad4d4

…xRestore Previously this expression contains a fragment similar to /aa*/ - have simplified this to /a+/.

vicb mentioned this issue Oct 28, 2016

Issue with Regexp on mobile safari 7 (DatePipe error on Browser Stack) angular/angular#12597

Closed

caridy closed this as completed in #244 Nov 16, 2016

mattlewis92 mentioned this issue Dec 29, 2016

Error while running the calendar on Safari mattlewis92/angular-calendar#115

Closed

viliks mentioned this issue Apr 1, 2017

IE10 "Syntax error in regular expression" when using DatePipe in Angular 2 #270

Open

alexduros mentioned this issue Apr 6, 2017

A polyfill for Intl should be included by default angular/angular-cli#1675

Closed

jerone mentioned this issue May 16, 2017

Intl.js with polyfill not working on Safari #256

Open

mattlewis92 mentioned this issue Jul 17, 2017

Calendar not working on iOS platform mattlewis92/angular-calendar#274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

createRegExpRestore explodes with an unmatched parenthesis #231

createRegExpRestore explodes with an unmatched parenthesis #231

azimux commented Sep 24, 2016

caridy commented Sep 25, 2016

azimux commented Sep 26, 2016 •

edited

Loading

MarkChrisLevy commented Oct 18, 2016

caridy commented Oct 18, 2016

mtlewis commented Oct 18, 2016

mtlewis commented Oct 18, 2016

azimux commented Oct 19, 2016

azimux commented Oct 19, 2016 •

edited

Loading

mtlewis commented Oct 20, 2016

mtlewis commented Oct 20, 2016

wojtekmaj commented Dec 16, 2016

fetis commented Mar 14, 2017

caridy commented Apr 3, 2017

Blasz commented May 2, 2017

EwanMcP commented May 8, 2017

jerone commented May 16, 2017

neutraali commented Oct 16, 2020

createRegExpRestore explodes with an unmatched parenthesis #231

createRegExpRestore explodes with an unmatched parenthesis #231

Comments

azimux commented Sep 24, 2016

caridy commented Sep 25, 2016

azimux commented Sep 26, 2016 • edited Loading

MarkChrisLevy commented Oct 18, 2016

caridy commented Oct 18, 2016

mtlewis commented Oct 18, 2016

mtlewis commented Oct 18, 2016

azimux commented Oct 19, 2016

azimux commented Oct 19, 2016 • edited Loading

mtlewis commented Oct 20, 2016

mtlewis commented Oct 20, 2016

wojtekmaj commented Dec 16, 2016

fetis commented Mar 14, 2017

caridy commented Apr 3, 2017

Blasz commented May 2, 2017

EwanMcP commented May 8, 2017

jerone commented May 16, 2017

neutraali commented Oct 16, 2020

azimux commented Sep 26, 2016 •

edited

Loading

azimux commented Oct 19, 2016 •

edited

Loading