This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Allow disable of RegExp cache/restore #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of cache/restore of RegExp properties has the potential to cause a number of issues. A perfect solution is not possible because it's not possible to determine the regex that was used to turn the cached input into the cached match and group matches. The current solution simply takes the lastMatch and escapes it, wrapping any match groups in parens. One problem with this approach is that when the match is very long, it will overrun the maximum length of a RegEx in JavaScript. In this commit, we add the capability to disable restore of RegExp properties entirely, via `IntlPolyfill.__disableRegExpRestore`.
|
Closing in favour of #201. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196.
The implementation of cache/restore of RegExp properties
has the potential to cause a number of issues. A perfect
solution is not possible because it's not possible to
determine the regex that was used to turn the cached input
into the cached match and group matches. The current
solution simply takes the lastMatch and escapes it,
wrapping any match groups in parens. One problem with
this approach is that when the match is very long, it
will overrun the maximum length of a RegEx in JavaScript.
In this commit, we add the capability to disable restore
of RegExp properties entirely, via
IntlPolyfill.__disableRegExpRestore.