-
Notifications
You must be signed in to change notification settings - Fork 215
Don't override .toLocaleString functions if they're already wired up to native Intl #58
Comments
About this particular issue, I was talking to @ericf while integrating the polyfills into Flickr last week, and it seems that we made a bad decision on |
So, you're saying define Generally, people should be advised to include it only if they need it. I'd even be fine with overriding native |
Yeah, my concrete proposal is:
that will cover the case of transparent inserting the polyfill in the page (conditionally or not), but also the case where you want to use the polyfill over the native implementation for a particular runtime. |
It seems that the |
- Include short, long and full templates from CLDR as part of the extraction task to combine time and date formats correctly based on http://unicode.org/reports/tr35/tr35-dates.html#availableFormats_appendItems - Diverge from spec becuase of bug #58 in ECMA 402 to requested options can overrule best match format as described here: tc39/ecma402#58 - Refactor the whole CLDR script to complain with the algo described here: http://unicode.org/reports/tr35/tr35-dates.html#availableFormats_appendItems
Currently, we avoid overriding
Intl
by defining asIntlPolyfill
. However,Number.prototype.toLocaleString
,Date.prototype.toLocaleString
and friends are still defined by our library and take the place of the native implementations.We should check that these functions are not already wired up to a native implementation of Intl before defining them ourselves.
The text was updated successfully, but these errors were encountered: