Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

string sorting in locales #18

Closed
thorsent opened this issue Jun 20, 2013 · 3 comments
Closed

string sorting in locales #18

thorsent opened this issue Jun 20, 2013 · 3 comments

Comments

@thorsent
Copy link

Not sure the status of the locale db but just noticed that months are being ordered with a string sort rather than a numeric sort. Also, days of the week are ordered based on string sort rather than the canonical ordering.

@andyearnshaw
Copy link
Owner

This is a regression I recently introduced when trying to keep the unnecessary file changes to a minimum. I'm pretty sure I know what the issue is and it shouldn't take me long to fix.

@andyearnshaw
Copy link
Owner

Done, thanks for the kick up the backside ;-) It's a quick and dirty fix, relying on the predictable iteration order for properties in V8, so something a little more robust might be required in the future if I get time and don't forget about it, but it shouldn't break any time soon and it's no worse than it was before I broke it.

@thorsent
Copy link
Author

The library is awesome. Thanks for the quick fix!

On Thu, Jun 20, 2013 at 7:37 PM, Andy Earnshaw notifications@github.comwrote:

Done, thanks for the kick up the backside ;-)


Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-19790591
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants