This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Fix RegExp.lastMatch on Firefox when it is undefined #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyearnshaw
added a commit
that referenced
this pull request
Jan 5, 2015
Fix RegExp.lastMatch on Firefox when it is undefined
|
Change looks harmless enough. Tests are still failing on SL because of unrelated issues that I haven't had chance to resolve yet. Cheers! |
|
Perfect, thanks! |
|
Hi, Has this been released yet? |
|
not yet, will be in 1.0.0-rc1, still working on that. |
|
I think you can work around it by doing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came accross the issue that sometimes in Firefox
RegExp.lastMatchis undefined and then thecreateRegExpRestore()Function fails.I hope the tests run properly, I couldn't test the Saucelabs tests because of not having an account.