-
Notifications
You must be signed in to change notification settings - Fork 215
Conversation
Implement GetOperands & PluralRuleSelection using make-plural.js
It seems to cover the whole spec, but I'm not sure about how the make-plurals are supposed to work, as when I try to just launch it, it errors with:
@eemeli recommendation ( zbraniecki#1 (comment) ) is:
which I'm not sure if it'll fly with the whole Intl.js requiring it to run. |
@caridy - but except of this error, I think the PR is ready for review. |
Any update on this @zbraniecki ? |
So, the PR is ready, but there's a bug on travis that I don't understand, and when I'm trying to manually test using It seems like both errors are related to babel and I'm not familiar with babel at all, so I don't know how to fix either of them. Need help. |
Hopefully fixed with zbraniecki#2. |
Fix make-plural import path, linter complaints & typos
The travis is fixed with zbraniecki#2 thank you @eemeli ! So it seems like this PR should be ready to be merged |
I applied availableLocales from make-plurals. I have no idea why travis failed now... |
@caridy ? |
Would appreciate to get this merged, how could I help? |
It's ready to land as far as I can tell. Pending @caridy to calm travis down and land it. |
ping @caridy @andyearnshaw what can we do to see this issue merged soon? Should @zbraniecki be granted to merge PR on this repo? |
Hi, this feature is a real need by there. Can we hope a merge soon ? |
intlObj['[[maximumFractionDigits]]'] = mxfd; | ||
|
||
// 12. If mnsd is not undefined or mxsd is not undefined, then | ||
if (mnsd !== undefined || mxsd !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zbraniecki we changed this one a little bit I think, can you update the implementation?
Thank you so much @caridy! Do you plan to make a release too? Would be able to upgrade https://github.com/Financial-Times/polyfill-service/issues/1097 this way. |
@shouze unfortunately I can't do it this week, but if there is anyone willing to help with the release, I can help :) |
Hi, any plan to release this soon? |
Am I correct in saying that this PR is not published yet on npm? |
Ok, let's start the PR.