This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Locale js modules #239
Closed
Locale js modules #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #218, which I'm still working on to try to come up with a good solution that works well in all environments. I don't think we can go with this approach considering that we are trying to reduce the massive size of this package, and including a new set of duplicate files for modules will make this package bigger. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use this in an environment where I don't have control over what's happening in the global scope of the page and so JSONP isn't an option. JSON isn't ideal for me, either.
Would you consider adding a version of locale-data that exports the config object?
I'm not seeing a nice diff of the meaningful changes in this PR. They're in commit 23c9972 in scripts/build-data.js.
23c9972