This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Separate out NumberFormatToString #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zbraniecki I will really like to keep the algo steps comments for easy evolution of those methods, you can do that either manually (if it is a small algo) or using the tool. |
zbraniecki
force-pushed
the
split-numberformat
branch
from
03aec35 to
bacab3b
Compare
|
@caridy - I used the tool and also cleaned up some comments in PartitionNumberFormat which were not incrementing and fixed alignment in the function which was broken. |
|
awesome, thanks! that's precisely why I want to use this :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following tc39/ecma402@2f9226d this change prepares Intl.js for PluralRules.