Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

locking down versions for babel-preset-es2015 and babel-preset-es201… #210

Merged
merged 1 commit into from
Aug 11, 2016
Merged

locking down versions for babel-preset-es2015 and babel-preset-es201… #210

merged 1 commit into from
Aug 11, 2016

Conversation

julka
Copy link
Contributor

@julka julka commented Aug 9, 2016

In a fresh install, babel-preset-es2015 and babel-preset-es2015-rollup are making built:lib fail. This diff locks down the version to resolve this issue.

With babel-preset-es2015 at ^6.1.18 or babel-preset-es2015-rollup at ^1.1.1, I see this error:

> babel-node scripts/build-lib

Intl.js/node_modules/babel-polyfill/node_modules/core-js/modules/es6.promise.js:123
    if(abrupt)throw abrupt.error;
              ^

Error: Error loading Intl.js/src/core.js: It looks like your Babel configuration specifies a module transformer. Please disable it. If you're using the "es2015" preset, consider using "es2015-rollup" instead. See https://github.com/rollup/rollup-plugin-babel#configuring-babel for more information
    at preflightCheck (Intl.js/node_modules/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:43:102)
    at transform$1 (Intl.js/node_modules/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:104:18)
    at Intl.js/node_modules/rollup/dist/rollup.js:7426:28
    at tryCatch (Intl.js/node_modules/rollup/dist/rollup.js:395:12)
    at invokeCallback (Intl.js/node_modules/rollup/dist/rollup.js:407:13)
    at Intl.js/node_modules/rollup/dist/rollup.js:168:7
    at flush (Intl.js/node_modules/rollup/dist/rollup.js:120:5)
    at nextTickCallbackWith0Args (node.js:420:9)
    at process._tickDomainCallback (node.js:390:13)
    at Function.Module.runMain (module.js:443:11)

…-rollup, as newer versions make build:lib fail
@caridy
Copy link
Collaborator

caridy commented Aug 11, 2016

Ok, I'm good with this one for now until I get a chance to update everything.

@caridy caridy merged commit c4c5186 into andyearnshaw:master Aug 11, 2016
@julka
Copy link
Contributor Author

julka commented Aug 11, 2016

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants