This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Provide a working unit test for Issue #192 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,3 +42,11 @@ assert(new IntlPolyfill.DateTimeFormat('en', { | |||
| month:'long', | |||
| year: 'numeric' | |||
| }).format(new Date('2016/01/16')), 'January 2016', 'month should be long'); | |||
|
|
|||
| // Issue #192 | |||
| assert((function () { | |||
There was a problem hiding this comment.
Thanks for adding the case. It would be nice if you can make the style like the others!
assert(new IntlPolyfill.DateTimeFormat('en-us', {
month:'long',
}).format(new Date(2016, 0, 1)), 'January', 'month should be long');
There was a problem hiding this comment.
@headcr4sh align with the other tests, and I can merge this in preparation for that fix.
|
Style has been adjusted and patch has been rebased on the latest master branch. |
|
thanks @headcr4sh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a working unit test for issue #192.