This repository was archived by the owner on Apr 14, 2021. It is now read-only.
BestFitFormatMatcher: Add new penalty as a pattern #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
force-pushed
the
patch/care-pattern-in-bestmatch
branch
4 times, most recently
from
628a8aa to
fbf021d
Compare
In the InitializeDateTimeFormat, pattern prop as a `_` is checked by diverging and it will be used when the value is matched.
watilde
force-pushed
the
patch/care-pattern-in-bestmatch
branch
from
fbf021d to
2655473
Compare
|
@watilde how does this help? just wondering if this moves the needle at all. |
|
+1 |
|
Oh, thanks for adding sanity check. For next time, I will include a test case into a patch 😺 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152 and #179.
In the InitializeDateTimeFormat, pattern prop as a
_is checked by diverging and it will be used when the value is matched.