-
Notifications
You must be signed in to change notification settings - Fork 215
Fix the tests don't run correctly on CI #167
Conversation
16d75ed
to
751e495
Compare
e0d20b3
to
ad99ae9
Compare
9af513c
to
f6f4532
Compare
33b8b46
to
6e22dab
Compare
@andyearnshaw @caridy Hi. I made ci tests run completely and I'd like to keep this PR as fix only the thing if it's ok. Could you please take a look into this when you have a time? Here are the results of ci tests: Master branch
This patch
Thanks. |
@@ -30,7 +30,7 @@ module.exports = function (grunt) { | |||
dest : 'tests/test262', | |||
src : [ | |||
'LICENSE', | |||
'test/intl402/*.js', | |||
'test/intl402/**/*.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some directories were added in test262/test/intl402 so this pattern should be **/*.js
@watilde thanks a lot for the help, I will be merging this later today. |
@watilde I went on and fixes the whole test harness to be able to run the latest test, locally, I'm getting 99 passing correctly, no failures, that's a huge improvements :), thanks a lot again. On travis I'm getting few failures:
But this is a huge step in the right direction. |
@caridy Wow I'm glad to hear that! I was trying to fix failed errors too, for latest tests(= As a first point I started fixing |
The tests doesn't work on local and CI as well. This PR is to just run tests without fixing actual test cases.