Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Fix the tests don't run correctly on CI #167

Merged
merged 11 commits into from
Apr 28, 2016

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Apr 27, 2016

The tests doesn't work on local and CI as well. This PR is to just run tests without fixing actual test cases.

@watilde watilde force-pushed the patch/failed-test branch from 16d75ed to 751e495 Compare April 27, 2016 01:27
@watilde watilde force-pushed the patch/failed-test branch from e0d20b3 to ad99ae9 Compare April 27, 2016 12:17
@watilde watilde force-pushed the patch/failed-test branch from 9af513c to f6f4532 Compare April 27, 2016 13:16
@watilde watilde force-pushed the patch/failed-test branch from 33b8b46 to 6e22dab Compare April 27, 2016 13:46
@watilde watilde changed the title [WIP] Fix failed test on CI Fix the tests don't run correctly on CI Apr 27, 2016
@watilde
Copy link
Contributor Author

watilde commented Apr 27, 2016

@andyearnshaw @caridy Hi. I made ci tests run completely and I'd like to keep this PR as fix only the thing if it's ok. Could you please take a look into this when you have a time? Here are the results of ci tests:

Master branch

This patch

Thanks.

@@ -30,7 +30,7 @@ module.exports = function (grunt) {
dest : 'tests/test262',
src : [
'LICENSE',
'test/intl402/*.js',
'test/intl402/**/*.js',
Copy link
Contributor Author

@watilde watilde Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some directories were added in test262/test/intl402 so this pattern should be **/*.js

@caridy
Copy link
Collaborator

caridy commented Apr 27, 2016

@watilde thanks a lot for the help, I will be merging this later today.

@caridy caridy merged commit 9edd6e1 into andyearnshaw:master Apr 28, 2016
@watilde watilde deleted the patch/failed-test branch April 28, 2016 22:24
@caridy
Copy link
Collaborator

caridy commented Apr 29, 2016

@watilde I went on and fixes the whole test harness to be able to run the latest test, locally, I'm getting 99 passing correctly, no failures, that's a huge improvements :), thanks a lot again.

On travis I'm getting few failures:

  • "passCount": 553,
  • "failCount": 18,

But this is a huge step in the right direction.

@watilde
Copy link
Contributor Author

watilde commented Apr 30, 2016

@caridy Wow I'm glad to hear that! I was trying to fix failed errors too, for latest tests(= grunt update-test262) on my local.

As a first point I started fixing 6.4 Timezone Names but finally I couldn't fix it. There was no way to get user's current time zone correctly because it's implemented in platform codes(e.g. win32, macos) and there is no interface without Intl native Object currently. Hence, I knew the reason why it was mentioned as Not Implemented in the README.md of this project. Well, I'm happy to support fix tests😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants