Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Added Intl.complete to bower main #114

Merged
merged 2 commits into from
Jun 23, 2015
Merged

Conversation

ollym
Copy link
Contributor

@ollym ollym commented Jun 23, 2015

Useful for build tools that rely on it

Useful for build tools that rely on it
@andyearnshaw
Copy link
Owner

The main reason I've been reluctant to do this is I don't want to make it too easy for someone to reference the "complete" file because it sounds better. I wouldn't like to be the guy sat on the train trying to browse a site that wants to download a 200KB (gzipped!) file on his mobile device over a 2G connection, just because the developer was too lazy to RTFM.

What build tools need this? Aren't they better off using NPM as a dependency manager?

@ollym
Copy link
Contributor Author

ollym commented Jun 23, 2015

@andyearnshaw I think then you need to add the locale-data folder to main because this library isn't usable without at least one of the locale files.

We're using a custom build system, similar to webpack / sprockets that resolves and pulls in bower dependencies based on the value of main.

@andyearnshaw
Copy link
Owner

Probably just locale-data/jsonp is needed then. If you'd like to edit your pull request or submit another, I'll merge it.

@caridy
Copy link
Collaborator

caridy commented Jun 23, 2015

👍

andyearnshaw added a commit that referenced this pull request Jun 23, 2015
Added Intl.complete to bower main [ci skip]
@andyearnshaw andyearnshaw merged commit 5a1288a into andyearnshaw:master Jun 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants