fixes #152, fixes #179: improving support for best bit on datatimeformat, follow up on PR #186

Author: caridy

src/12.datetimeformat.js

@@ -666,10 +666,11 @@ function BestFitFormatMatcher (options, formats) {
             //     1. Let formatProp be the result of calling the [[Get]] internal method of format with argument property.
             let formatProp = hop.call(format, property) ? format[property] : undefined;
 
+            // Diverging: using the default properties produced by the pattern/skeleton
+            // to match it with user options, and apply a penalty
             let patternProp = hop.call(format._, property) ? format._[property] : undefined;
-
             if (optionsProp !== patternProp) {
-              score -= patternPenalty;
+                score -= patternPenalty;
             }
 
             // iv. If optionsProp is undefined and formatProp is not undefined, then decrease score by

tests/sanity.js

@@ -25,3 +25,20 @@ assert(new IntlPolyfill.DateTimeFormat('en', {
     month:'numeric',
     day: 'numeric'
 }).format(new Date('2016/05/16')), '5/16', 'month and day');
+
+// Issue #152
+assert(new IntlPolyfill.DateTimeFormat('en-US', {
+    hour: 'numeric',
+    minute: 'numeric'
+}).format(new Date(1456859319008)), '2:08 PM', 'missing leading 0 on minutes');
+assert(new IntlPolyfill.DateTimeFormat('en-GB', {
+  hour: '2-digit',
+  hour12: false,
+  minute: 'numeric'
+}).format(new Date(1983, 9, 13)), '00:00', 'GB should use 2-digits for hours and minutes without hour12');
+
+// issue #179
+assert(new IntlPolyfill.DateTimeFormat('en', {
+    month:'long',
+    year: 'numeric'
+}).format(new Date('2016/01/16')), 'January 2016', 'month should be long');